Skip to content

Commit deef497

Browse files
remove redundant code from handling incoming metadata request
1 parent 0542728 commit deef497

File tree

2 files changed

+8
-23
lines changed

2 files changed

+8
-23
lines changed

packages/core/src/lib/metadata/index.ts

+7-22
Original file line numberDiff line numberDiff line change
@@ -28,29 +28,14 @@ class Metadata extends BaseProtocol {
2828
* Handle an incoming metadata request
2929
*/
3030
private async onRequest(streamData: IncomingStreamData): Promise<void> {
31-
const encodedRpcQuery = proto_metadata.WakuMetadataRequest.encode(
32-
this.shardInfo
33-
);
34-
35-
const res = await pipe(
36-
[encodedRpcQuery],
37-
lp.encode,
38-
streamData.stream,
39-
lp.decode,
40-
async (source) => await all(source)
41-
);
31+
try {
32+
const encodedResponse = proto_metadata.WakuMetadataResponse.encode(
33+
this.shardInfo
34+
);
4235

43-
const bytes = new Uint8ArrayList();
44-
res.forEach((chunk) => {
45-
bytes.append(chunk);
46-
});
47-
48-
const shardInfoRes = proto_metadata.WakuMetadataResponse.decode(bytes);
49-
if (!shardInfoRes) {
50-
log.error("WakuMetadata response is undefined");
51-
}
52-
if (!shardInfoRes.clusterId) {
53-
log.error("WakuMetadata response clusterId is undefined");
36+
await pipe([encodedResponse], lp.encode, streamData.stream);
37+
} catch (error) {
38+
log.error("Error handling metadata request", error);
5439
}
5540
}
5641

packages/tests/tests/metadata.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { tearDownNodes } from "../src/index.js";
88
import { makeLogFileName } from "../src/log_file.js";
99
import { NimGoNode } from "../src/node/node.js";
1010

11-
describe("Metadata Protocol", () => {
11+
describe.only("Metadata Protocol", () => {
1212
describe("Locally Run Nodes", () => {
1313
let waku: LightNode;
1414
let nwaku1: NimGoNode;

0 commit comments

Comments
 (0)