use Infinity instead of 0 to check already dialed

Author: danisharora099

packages/core/src/lib/connection_manager.ts

@@ -38,7 +38,7 @@ export class ConnectionManager
   private dialAttemptsForPeer: Map<string, number> = new Map();
   private dialErrorsForPeer: Map<string, any> = new Map();
 
-  private currentActiveDialCount = 0;
+  private currentActiveParallelDialCount = 0;
   private pendingPeerDialQueue: Array<PeerId> = [];
 
   public static create(
@@ -181,7 +181,7 @@ export class ConnectionManager
   }
 
   private async dialPeer(peerId: PeerId): Promise<void> {
-    this.currentActiveDialCount += 1;
+    this.currentActiveParallelDialCount += 1;
     let dialAttempt = 0;
     while (dialAttempt < this.options.maxDialAttemptsForPeer) {
       try {
@@ -195,9 +195,9 @@ export class ConnectionManager
           conn.tags = Array.from(new Set([...conn.tags, ...tags]));
         });
 
-        // instead of deleting the peer from the peer store, we set the dial attempt to 0
+        // instead of deleting the peer from the peer store, we set the dial attempt to Infinity
         // this helps us keep track of peers that have been dialed before
-        this.dialAttemptsForPeer.set(peerId.toString(), 0);
+        this.dialAttemptsForPeer.set(peerId.toString(), Infinity);
 
         // Dialing succeeded, break the loop
         break;
@@ -221,7 +221,7 @@ export class ConnectionManager
     }
 
     // Always decrease the active dial count and process the dial queue
-    this.currentActiveDialCount--;
+    this.currentActiveParallelDialCount--;
     this.processDialQueue();
 
     // If max dial attempts reached and dialing failed, delete the peer
@@ -273,7 +273,7 @@ export class ConnectionManager
   private processDialQueue(): void {
     if (
       this.pendingPeerDialQueue.length > 0 &&
-      this.currentActiveDialCount < this.options.maxParallelDials
+      this.currentActiveParallelDialCount < this.options.maxParallelDials
     ) {
       const peerId = this.pendingPeerDialQueue.shift();
       if (!peerId) return;
@@ -319,7 +319,7 @@ export class ConnectionManager
   private async attemptDial(peerId: PeerId): Promise<void> {
     if (!(await this.shouldDialPeer(peerId))) return;
 
-    if (this.currentActiveDialCount >= this.options.maxParallelDials) {
+    if (this.currentActiveParallelDialCount >= this.options.maxParallelDials) {
       this.pendingPeerDialQueue.push(peerId);
       return;
     }
@@ -438,7 +438,7 @@ export class ConnectionManager
     // If the peer is already in the peer store or has an active dial attempt, don't dial it
     if (
       this.dialAttemptsForPeer.has(peerId.toString()) &&
-      this.dialAttemptsForPeer.get(peerId.toString()) === 0
+      this.dialAttemptsForPeer.get(peerId.toString()) === Infinity
     ) {
       log(
         `Peer ${peerId.toString()} has already been attempted dial before, or already has a dial attempt in progress, skipping dial`