Skip to content

Commit 9494041

Browse files
fix: ensure that websocket multiaddrs are returned from ENR (#1275)
Closes: #1271 Co-authored-by: Danish Arora <35004822+danisharora099@users.noreply.github.com>
1 parent c68f29a commit 9494041

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

packages/enr/src/enr.spec.ts

+8-1
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,9 @@ describe("ENR", function () {
311311
const ip6 = "::1";
312312
const tcp = 8080;
313313
const udp = 8080;
314+
const wsMultiaddr = multiaddr(
315+
"/dns4/node-01.do-ams3.wakuv2.prod.statusim.net/tcp/8000/wss"
316+
);
314317
let peerId: PeerId;
315318
let enr: ENR;
316319

@@ -323,6 +326,7 @@ describe("ENR", function () {
323326
enr.udp = udp;
324327
enr.tcp6 = tcp;
325328
enr.udp6 = udp;
329+
enr.multiaddrs = [wsMultiaddr];
326330
});
327331

328332
it("should properly create location multiaddrs - udp4", () => {
@@ -391,7 +395,7 @@ describe("ENR", function () {
391395
const peerInfo = enr.peerInfo!;
392396
console.log(peerInfo);
393397
expect(peerInfo.id.toString()).to.equal(peerId.toString());
394-
expect(peerInfo.multiaddrs.length).to.equal(4);
398+
expect(peerInfo.multiaddrs.length).to.equal(5);
395399
expect(peerInfo.multiaddrs.map((ma) => ma.toString())).to.contain(
396400
multiaddr(`/ip4/${ip4}/tcp/${tcp}`).toString()
397401
);
@@ -404,6 +408,9 @@ describe("ENR", function () {
404408
expect(peerInfo.multiaddrs.map((ma) => ma.toString())).to.contain(
405409
multiaddr(`/ip6/${ip6}/udp/${udp}`).toString()
406410
);
411+
expect(peerInfo.multiaddrs.map((ma) => ma.toString())).to.contain(
412+
wsMultiaddr.toString()
413+
);
407414
});
408415
});
409416

packages/enr/src/enr.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,8 @@ export class ENR extends RawEnr implements IEnr {
9999
}
100100

101101
const _multiaddrs = this.multiaddrs ?? [];
102-
multiaddrs.concat(_multiaddrs);
103102

104-
return multiaddrs;
103+
return multiaddrs.concat(_multiaddrs);
105104
}
106105

107106
get peerInfo(): PeerInfo | undefined {

0 commit comments

Comments
 (0)