fix: remove initialising peer-exchange while creating a node (#1158)

* remove peer-exchange from @waku/core
- also removes the manual test for peer-exchange (assumption is that the
only way to initialise peer-exchange is through libp2p's peerDiscovery and
not manually) (ref:
#1158 (comment))

 # Please enter the commit message for your changes. Lines
starting

* fix: build

* update interop test

* decrease test duration for px auto discovery

* rm: only for tests

* address comment

Author: danisharora099

package-lock.json

@@ -60,14 +60,6 @@ export async function waitForRemotePeer(
     promises.push(waitForConnectedPeer(waku.filter));
   }
 
-  if (protocols.includes(Protocols.PeerExchange)) {
-    if (!waku.peerExchange)
-      throw new Error(
-        "Cannot wait for Peer Exchange peer: protocol not mounted"
-      );
-    promises.push(waitForConnectedPeer(waku.peerExchange));
-  }
-
   if (timeoutMs) {
     await rejectOnTimeout(
       Promise.all(promises),

packages/core/src/lib/wait_for_remote_peer.ts

@@ -6,10 +6,8 @@ import type { Multiaddr } from "@multiformats/multiaddr";
 import type {
   IFilter,
   ILightPush,
-  IPeerExchange,
   IRelay,
   IStore,
-  PeerExchangeComponents,
   Waku,
 } from "@waku/interfaces";
 import { Protocols } from "@waku/interfaces";
@@ -53,7 +51,6 @@ export class WakuNode implements Waku {
   public store?: IStore;
   public filter?: IFilter;
   public lightPush?: ILightPush;
-  public peerExchange?: IPeerExchange;
 
   private pingKeepAliveTimers: {
     [peer: string]: ReturnType<typeof setInterval>;
@@ -67,8 +64,7 @@ export class WakuNode implements Waku {
     libp2p: Libp2p,
     store?: (libp2p: Libp2p) => IStore,
     lightPush?: (libp2p: Libp2p) => ILightPush,
-    filter?: (libp2p: Libp2p) => IFilter,
-    peerExchange?: (components: PeerExchangeComponents) => IPeerExchange
+    filter?: (libp2p: Libp2p) => IFilter
   ) {
     this.libp2p = libp2p;
 
@@ -82,13 +78,6 @@ export class WakuNode implements Waku {
       this.lightPush = lightPush(libp2p);
     }
 
-    if (peerExchange) {
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      // @ts-ignore: Libp2p is now hiding internal components but peer discovery
-      // implementation still expect to receive said components.
-      this.peerExchange = peerExchange(libp2p.components);
-    }
-
     if (isRelay(libp2p.pubsub)) {
       this.relay = libp2p.pubsub;
     }
@@ -97,8 +86,7 @@ export class WakuNode implements Waku {
       "Waku node created",
       this.libp2p.peerId.toString(),
       `relay: ${!!this.relay}, store: ${!!this.store}, light push: ${!!this
-        .lightPush}, filter: ${!!this.filter}, peer exchange: ${!!this
-        .peerExchange} `
+        .lightPush}, filter: ${!!this.filter}} `
     );
 
     this.pingKeepAliveTimers = {};
@@ -156,7 +144,6 @@ export class WakuNode implements Waku {
       this.store && _protocols.push(Protocols.Store);
       this.filter && _protocols.push(Protocols.Filter);
       this.lightPush && _protocols.push(Protocols.LightPush);
-      this.peerExchange && _protocols.push(Protocols.PeerExchange);
     }
 
     const codecs: string[] = [];
@@ -197,16 +184,6 @@ export class WakuNode implements Waku {
       }
     }
 
-    if (_protocols.includes(Protocols.PeerExchange)) {
-      if (this.peerExchange) {
-        codecs.push(this.peerExchange.multicodec);
-      } else {
-        log(
-          "Peer Exchange codec not included in dial codec: protocol not mounted locally"
-        );
-      }
-    }
-
     log(`Dialing to ${peer.toString()} with protocols ${_protocols}`);
 
     return this.libp2p.dialProtocol(peer, codecs);