-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme settings gets whiped after a certain amount of time #373
Comments
For me, it never changed back to undead, its may related to your browser erasing local storage from time to time? Line 222 in 1aaea37
LocalStorage also doesn't have an expiry date. |
I just have chrome and realized that this happened some times allready. Not a big deal just wanted to mark it here so when I have some time again, I might fix it ^^ |
This happens for me on mobile (S20 android, chrome browser) but not on desktop strangely. |
It just got whiped for me again and i realized I was on www.w3champions.com. When I went without www. it was my old setting again. Maybe we should redirect www. to the normal site anyways? That might also be weird with the token for example. But my guess is, that it has something to do with that. |
yes i know, the local storage was empty on www but my guess is that I have been there mutliple times aswell and set it to my theme. I just wanted this as an reminder and maybe someone has an idea why that happens. |
Hey everyone, Just checking in on this. So we've confirmed that localStorage is different for each origin so you might get different results depending on whether you got to the tld or the www subdomain. @modmoto suggested that we do a redirect from www to the tld (or perhaps vice versa) which would solve the issue of having multiple localStorage's for the same user perceived site. The localStorage spec indicates that the storage doesn't expire but could be cleared by the user or for deemed security reasons (whatever that means). Has anyone been able to confirm that localStorage has actually expired for the same domain on mobile or desktop? |
Not sure on that question about localStorage but I agree re-routing the URL is probably the best solution to this. |
Every once in a while the theme setting in the local storage vanishes and you get undead as a default theme. Maybe related to a deployment?
The text was updated successfully, but these errors were encountered: