Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect-src test suite allows multiple non-interopable implementations. #706

Open
lukewarlow opened this issue Jan 30, 2025 · 2 comments
Open
Labels
interop Implementations are not interoperable with each other

Comments

@lukewarlow
Copy link
Member

lukewarlow commented Jan 30, 2025

I've found that the test suite for connect-src has multiple competing pass states which should be addressed, I've raised web-platform-tests/wpt#50387 on WPT but wanted to bring it to this groups attention too.

This leads to a current situation where WebKit throws for EventSource and WebSocket when it shouldn't be (per Firefox and Chromium and I think the spec see #120 ).

Idk if there are other examples of real interop issues as a result but there could be.

https://bugs.webkit.org/show_bug.cgi?id=286744

@ciaramcmullin ciaramcmullin added the needs concrete proposal Moving the issue forward requires someone to figure out a detailed plan label Feb 10, 2025
@dveditz dveditz added interop Implementations are not interoperable with each other and removed needs concrete proposal Moving the issue forward requires someone to figure out a detailed plan labels Feb 12, 2025
@dveditz
Copy link
Member

dveditz commented Feb 12, 2025

Thanks, Luke. Is there anyone who thinks the spec is ambiguous and needs changing? Back in #120 @annevk agreed with what chromium and gecko are doing now, so I think we're good wrt to the spec. You've filed an issue to change the test itself. I think the only thing to do in this repo/issue is make sure Apple folks agree and that there's a webkit bug on file. After that we can resolve the CSP copy of the issue

@annevk
Copy link
Member

annevk commented Feb 28, 2025

Let me now agree on behalf of WebKit that we should fix this bug. Thanks for finding it @lukewarlow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interop Implementations are not interoperable with each other
Projects
None yet
Development

No branches or pull requests

4 participants