Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to saxon 9.8.0-7 #830

Merged
merged 2 commits into from
Feb 10, 2018
Merged

update to saxon 9.8.0-7 #830

merged 2 commits into from
Feb 10, 2018

Conversation

mkraetke
Copy link
Contributor

As @raducoravu mentioned in #674 (comment), Saxon 9.8.0-7 HE supports XSLT 1.0 again. So I've made some minor changes to XMLValidator.java related to some API differences between Saxon 9.7 and 9.8. All tests have been passed.

@mkraetke mkraetke mentioned this pull request Feb 10, 2018
Closed
@tofi86 tofi86 requested review from tofi86 and rdeltour February 10, 2018 14:11
@tofi86 tofi86 added type: improvement The issue suggests an improvement of an existing feature refactoring labels Feb 10, 2018
@tofi86 tofi86 added this to the 4.1.0 milestone Feb 10, 2018
@tofi86
Copy link
Collaborator

tofi86 commented Feb 10, 2018

refs #822 (update to Saxon 9.7)

@tofi86
Copy link
Collaborator

tofi86 commented Feb 10, 2018 •
edited
Loading

Thanks for contributing this as a PullRequest, Martin! 👏

I'm wondering why you updated to 9.8.0-7 instead of latest 9.8.0-8 released 5 days ago?

@mkraetke
Copy link
Contributor Author

Because Saxon 9.8.0-8 was just released 5 days ago and I probably missed this :) But my patch works with 9.8.0-8 as well, so feel free to change the dependency in the pom.xml later.

rdeltour
rdeltour approved these changes Feb 10, 2018
View reviewed changes
Copy link
Member

@rdeltour rdeltour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Martin 👍
@tofi86 should we change the version to 9.8.0-8 before merging?

@tofi86
Copy link
Collaborator

tofi86 commented Feb 10, 2018

Yeah, I suggest we should use the latest version

tofi86
tofi86 requested changes Feb 10, 2018
View reviewed changes
Copy link
Collaborator

@tofi86 tofi86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkraetke any chance you could push the version change? otherwise @rdeltour or me will merge manually from the commandline and change it...

@mkraetke
Copy link
Contributor Author

OK, I've changed the dependency to version 9.8.0-8 in the pom.xml

@tofi86 tofi86 merged commit bf10f38 into w3c:master Feb 10, 2018
@tofi86
Copy link
Collaborator

tofi86 commented Feb 10, 2018

Merged. Thanks Martin! 🎉

@tofi86 tofi86 mentioned this pull request Feb 10, 2018
Closed
@tofi86
Copy link
Collaborator

tofi86 commented Feb 10, 2018

#XmlPragueSuccessStory 🥇

@rdeltour rdeltour mentioned this pull request Nov 12, 2018
Closed
@rdeltour rdeltour added type: improvement The issue suggests an improvement of an existing feature and removed type: improvement The issue suggests an improvement of an existing feature labels Nov 12, 2018
@sideshowbarker sideshowbarker mentioned this pull request Dec 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tofi86 tofi86 tofi86 approved these changes

@rdeltour rdeltour rdeltour approved these changes

Assignees
No one assigned
Labels
type: improvement The issue suggests an improvement of an existing feature
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mkraetke @tofi86 @rdeltour