[cssom-view-1] Add dictionary default values #4233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as non substantive for IPR from ash-nazg. |
dbaron
reviewed
Aug 22, 2019
| @@ -1072,12 +1072,12 @@ dictionary ScrollIntoViewOptions : ScrollOptions { | |||
| partial interface Element { | |||
| DOMRectList getClientRects(); | |||
| [NewObject] DOMRect getBoundingClientRect(); | |||
| void scrollIntoView(optional (boolean or ScrollIntoViewOptions) arg); | |||
| void scroll(optional ScrollToOptions options); | |||
| void scrollIntoView(optional (boolean or ScrollIntoViewOptions) arg = {}); | |||
There was a problem hiding this comment.
Are you sure this is the right thing given the (boolean or ScrollIntoViewOptions)?
There was a problem hiding this comment.
Yes. Previously the default value was implicitly an empty dictionary when the union includes non-required dictionary type, and now it must be explicit.
There was a problem hiding this comment.
Check out the relevant spec change: https://github.com/heycam/webidl/pull/750/files#diff-ec9cfa5f3f35ec1f84feb2e59686c34dR2245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required after whatwg/webidl#750. (Found from web-platform-tests/wpt#18382)