Skip to content

Commit eba6452

Browse files
dipamcDipam Chakrabortyvwxyzjn
authored
Match PPG implementation (#186)
* added nit changes from ppg code * change observation buffer to uint8 * sample full rollouts * minor device fix * update optimizer settings * add ppg documentation * update mkdocs * update images to png for codespell errors * trigger CI * Minor format change * format by running `pre-commit` * removes trailing space * Add an extra note * argument names and documentation changes * add capture video * add experiment report * Update documentation * Quick css fix * Update documentation * Fix documentation for PPO * Add benchmark commands * Add benchmark commands * add metrics section * Add more docs * Quick fix on ddpg docs * Add procgen test cases * Update CI * test CI * test ci * Update tests * normalization axis documentation Co-authored-by: Dipam Chakraborty <dipam@aicrowd.com> Co-authored-by: Costa Huang <costa.huang@outlook.com>
1 parent ab1c22f commit eba6452

18 files changed

+696
-11
lines changed

.github/workflows/pre-commit.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
name: pre-commit
22

33
on:
4+
push:
5+
branches: [ master ]
46
pull_request:
5-
branches: [ '*' ]
7+
branches: [ master ]
68
jobs:
79
build:
810
runs-on: ubuntu-latest

.github/workflows/tests.yaml

+31
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ on:
55
- '**/README.md'
66
- 'docs/**/*'
77
- 'cloud/**/*'
8+
pull_request:
9+
paths-ignore:
10+
- '**/README.md'
11+
- 'docs/**/*'
12+
- 'cloud/**/*'
813
jobs:
914
test-core-envs:
1015
strategy:
@@ -88,6 +93,32 @@ jobs:
8893
- name: Run pybullet tests
8994
run: poetry run pytest tests/test_pybullet.py
9095

96+
test-procgen-envs:
97+
strategy:
98+
fail-fast: false
99+
matrix:
100+
python-version: [3.8]
101+
poetry-version: [1.1.11]
102+
os: [ubuntu-18.04, macos-latest, windows-latest]
103+
runs-on: ${{ matrix.os }}
104+
steps:
105+
- uses: actions/checkout@v2
106+
- uses: actions/setup-python@v2
107+
with:
108+
python-version: ${{ matrix.python-version }}
109+
- name: Run image
110+
uses: abatilo/actions-poetry@v2.0.0
111+
with:
112+
poetry-version: ${{ matrix.poetry-version }}
113+
114+
# procgen tests
115+
- name: Install core dependencies
116+
run: poetry install -E "pytest procgen"
117+
- name: Downgrade setuptools
118+
run: poetry run pip install setuptools==59.5.0
119+
- name: Run pybullet tests
120+
run: poetry run pytest tests/test_procgen.py
121+
91122

92123
test-mujoco-envs:
93124
strategy:

benchmark/ppg.sh

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# export WANDB_ENTITY=openrlbenchmark
2+
3+
poetry install -E procgen
4+
xvfb-run -a python -m cleanrl_utils.benchmark \
5+
--env-ids starpilot bossfight bigfish \
6+
--command "poetry run python cleanrl/ppg_procgen.py --track --capture-video" \
7+
--num-seeds 3 \
8+
--workers 1

cleanrl/ddpg_continuous_action.py

-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
# docs and experiment results can be found at https://docs.cleanrl.dev/rl-algorithms/ddpg/#ddpg_continuous_actionpy
2-
# docs and experiment results can be found at
3-
# https://docs.cleanrl.dev/rl-algorithms/ddpg/#ddpg_continuous_actionpy
4-
52
import argparse
63
import os
74
import random

0 commit comments

Comments
 (0)