Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VInput/VMessages): move aria attributes to details #20420

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix(VInput/VMessages): move aria attributes to details #20420

merged 1 commit into from
Jan 24, 2025

Conversation

paul-thebaud
Copy link
Contributor

Description

This PR moves id, role="alert" and aria-live="polite" attributes from VMessages to VInput details content.
This improve ARIA support for additional details that are not messages, such as counter or other custom details slot.

Markup:

<template>
<v-app>
  <v-container>
    <v-textarea label="Body" maxlength="255" counter />
  </v-container>
</v-app>
</template>

@paul-thebaud
Copy link
Contributor Author

paul-thebaud commented Sep 19, 2024 •
edited
Loading

Can someone review this one @johnleider or @KaelWD please?
Is there something blocking?

@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected a11y Accessibility issue labels Oct 28, 2024
@paul-thebaud
Copy link
Contributor Author

Hello @johnleider and @KaelWD, what's wrong with this PR? Should I change something to get it merged?

@johnleider
Copy link
Member

Can you reach out to me in Discord please? https://community.vuetifyjs.com/

@paul-thebaud
Copy link
Contributor Author

@johnleider, done inside #vuetify-3-help.

@johnleider johnleider requested a review from KaelWD November 6, 2024 15:17
@paul-thebaud
Copy link
Contributor Author

Hello @KaelWD, just rebased my branch on master. This is ready for your review and merging if everything is ok 🎉

@johnleider johnleider changed the title fix(a11y): define whole input details as live instead of just messages fix(VInput/VMessages): move aria attributes to details Jan 24, 2025
@johnleider johnleider merged commit d1ed47c into vuetifyjs:master Jan 24, 2025
10 checks passed
@johnleider johnleider added this to the v3.7.x milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnleider johnleider johnleider approved these changes

@KaelWD KaelWD Awaiting requested review from KaelWD

Assignees

@paul-thebaud paul-thebaud

Labels
a11y Accessibility issue T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.7.x
Development

Successfully merging this pull request may close these issues.
3 participants
@paul-thebaud @johnleider @MajesticPotatoe