-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VSelect/VAutocomplete/VCombobox): respect click outside #20004
Merged
+55
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your changes look good but I'm curious as to what @KaelWD thinks. |
e20cfec
to
2766105
Compare
4c970f9
to
6a3285f
Compare
johnleider
previously approved these changes
Jan 29, 2025
KaelWD
pushed a commit
that referenced
this pull request
Jan 30, 2025
fixes #20003 Co-authored-by: John Leider <john@vuetifyjs.com>
KaelWD
added a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C: VAutocomplete
C: VCombobox
C: VSelect
T: bug
Functionality that does not work as intended/expected
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20003
Cause
Click outside isn't triggered due to blur is triggered by "mousedown" which is before click outside happens
Solution
When "mousedown outside", menu shouldn't be closed as it will be closed by "click outside" later. But it should be closed when blur is triggered by TAB or calling
blur()
from javascriptMarkup: