Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): add null check for current dark check #19408

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix(theme): add null check for current dark check #19408

merged 1 commit into from
Mar 15, 2024

Conversation

webdevnerdstuff
Copy link
Contributor

Description

Adding in a null check if dark is undefined

Markup:

if (current.value?.dark) {
  createCssClass(lines, ':root', ['color-scheme: dark'])
}

@johnleider johnleider added T: bug Functionality that does not work as intended/expected E: theme Theme composable labels Mar 15, 2024
@johnleider johnleider added this to the v3.5.x milestone Mar 15, 2024
@johnleider johnleider changed the title Fix adding a null check fix(theme): add null check for current dark check Mar 15, 2024
@johnleider johnleider merged commit 5e07860 into vuetifyjs:master Mar 15, 2024
9 of 10 checks passed
@KaelWD
Copy link
Member

KaelWD commented Mar 15, 2024

  • Why would this be null?
  • There's other usages of this in genCssVariables that are unchecked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnleider johnleider johnleider approved these changes

Assignees

@webdevnerdstuff webdevnerdstuff

Labels
E: theme Theme composable T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.5.x
Development

Successfully merging this pull request may close these issues.
3 participants
@webdevnerdstuff @KaelWD @johnleider