Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to translate some labels #955

Closed
4 tasks done
soetz opened this issue Jul 9, 2022 · 2 comments · Fixed by #1339
Closed
4 tasks done

Make it possible to translate some labels #955

soetz opened this issue Jul 9, 2022 · 2 comments · Fixed by #1339
Labels
theme Related to the theme

Comments

@soetz
Copy link

soetz commented Jul 9, 2022

Is your feature request related to a problem? Please describe.

This issue is very similar to #893

I noticed some more text that is hardcoded into the default theme components, and it would be super if they were translateable.

Describe the solution you'd like

Same as #893, themeConfig options would do the job.

I guess they could be grouped with themeConfig.outlineTitle, themeConfig.lastUpdatedText and themeConfig.docFooter under something like themeConfig.translate or themeConfig.customText?

Describe alternatives you've considered

We can still extend the theme to get this functionality, so this is not critical.

Additional context

No response

Validations

@brc-dd brc-dd added enhancement theme Related to the theme labels Jul 9, 2022
@brc-dd
Copy link
Member

brc-dd commented Jul 10, 2022

Hi! Yeah we would fix all these issues. In the meanwhile, you can track #631.

Can you help us figure out all such labels to override?

@soetz
Copy link
Author

soetz commented Jul 11, 2022

Good to know, thanks!

I’ve looked a bit and those are the only ones that I found, but of course if I notice new ones I’ll add them :)

This was referenced Sep 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme Related to the theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants