Skip to content

Commit fe03590

Browse files
Merge pull request #238 from Rajadeepan/events
Adding Events for Action
2 parents 60e31af + 657a7df commit fe03590

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

pkg/apis/batch/v1alpha1/job.go

+2
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,8 @@ const (
112112
PVCError JobEvent = "PVCError"
113113
// PodGroupError pod grp error event is generated if error happens during pod grp creation
114114
PodGroupError JobEvent = "PodGroupError"
115+
//ExecuteAction action issued event for each action
116+
ExecuteAction JobEvent = "ExecuteAction"
115117
)
116118

117119
// Event represent the phase of Job, e.g. pod-failed.

pkg/controllers/job/job_controller.go

+8
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ limitations under the License.
1717
package job
1818

1919
import (
20+
"fmt"
21+
2022
"github.com/golang/glog"
2123

2224
"k8s.io/api/core/v1"
@@ -38,6 +40,7 @@ import (
3840
kbinfo "github.com/kubernetes-sigs/kube-batch/pkg/client/informers/externalversions/scheduling/v1alpha1"
3941
kblister "github.com/kubernetes-sigs/kube-batch/pkg/client/listers/scheduling/v1alpha1"
4042

43+
vkbatchv1 "volcano.sh/volcano/pkg/apis/batch/v1alpha1"
4144
vkver "volcano.sh/volcano/pkg/client/clientset/versioned"
4245
vkscheme "volcano.sh/volcano/pkg/client/clientset/versioned/scheme"
4346
vkinfoext "volcano.sh/volcano/pkg/client/informers/externalversions"
@@ -239,6 +242,11 @@ func (cc *Controller) processNextReq() bool {
239242
glog.V(3).Infof("Execute <%v> on Job <%s/%s> in <%s> by <%T>.",
240243
action, req.Namespace, req.JobName, jobInfo.Job.Status.State.Phase, st)
241244

245+
if action != vkbatchv1.SyncJobAction {
246+
cc.recordJobEvent(jobInfo.Job.Namespace, jobInfo.Job.Name, vkbatchv1.ExecuteAction, fmt.Sprintf(
247+
"Start to execute action %s ", action))
248+
}
249+
242250
if err := st.Execute(action); err != nil {
243251
glog.Errorf("Failed to handle Job <%s/%s>: %v",
244252
jobInfo.Job.Namespace, jobInfo.Job.Name, err)

0 commit comments

Comments
 (0)