add golangci-lint to project

fix #792

Author: masihtehrani

.golangci.yml

@@ -0,0 +1,71 @@
+# output configuration options
+output:
+  # colored-line-number|line-number|json|tab|checkstyle|code-climate, default is "colored-line-number"
+  format: colored-line-number
+
+  # print lines of code with issue, default is true
+  print-issued-lines: true
+
+  # print linter name in the end of issue text, default is true
+  print-linter-name: true
+
+linters:
+  # please, do not use `enable-all`: it's deprecated and will be removed soon.
+  # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
+  disable-all: true
+  enable:
+    - bodyclose
+    - deadcode
+    - depguard
+    - dogsled
+    - dupl
+    - errcheck
+    - funlen
+    - gochecknoinits
+    - goconst
+    - gocritic
+    - gocyclo
+    - gofmt
+    - goimports
+    - golint
+    - gomnd
+    - goprintffuncname
+    - gosec
+    - gosimple
+    - govet
+    - ineffassign
+    - interfacer
+    - lll
+    - misspell
+    - nakedret
+    - rowserrcheck
+    - scopelint
+    - staticcheck
+    - structcheck
+    - stylecheck
+    - typecheck
+    - unconvert
+    - unparam
+    - unused
+    - varcheck
+    - whitespace
+    - gocognit
+    - godox
+    - maligned
+    - prealloc
+    - wsl
+    - godot
+    - nestif
+    - gomodguard
+    - asciicheck
+
+issues:
+  # Excluding configuration per-path, per-linter, per-text and per-source
+  exclude-rules:
+    - path: _test\.go
+      linters:
+        - gomnd
+    - path: test
+      linters:
+        - gomnd
+        - dupl

Makefile

@@ -89,6 +89,10 @@ verify:
 	hack/verify-gencode.sh
 	hack/verify-vendor.sh
 
+lint: ## Lint the files
+	golangci-lint version
+	golangci-lint run
+
 verify-generated-yaml:
 	./hack/check-generated-yaml.sh
 

pkg/cli/job/run.go

@@ -128,7 +128,7 @@ func readFile(filename string) (*vcbatch.Job, error) {
 
 	var job vcbatch.Job
 	if err := yaml.Unmarshal(file, &job); err != nil {
-		return nil, fmt.Errorf("Failed to unmarshal file, err:  %v", err)
+		return nil, fmt.Errorf("failed to unmarshal file, err:  %v", err)
 	}
 
 	return &job, nil

pkg/cli/queue/delete.go

@@ -50,7 +50,7 @@ func DeleteQueue() error {
 	}
 
 	if len(deleteQueueFlags.Name) == 0 {
-		return fmt.Errorf("Queue name must be specified")
+		return fmt.Errorf("queue name must be specified")
 	}
 
 	queueClient := versioned.NewForConfigOrDie(config)

pkg/cli/queue/operate.go

@@ -67,7 +67,7 @@ func OperateQueue() error {
 	}
 
 	if len(operateQueueFlags.Name) == 0 {
-		return fmt.Errorf("Queue name must be specified")
+		return fmt.Errorf("queue name must be specified")
 	}
 
 	var action v1alpha1.Action
@@ -79,7 +79,7 @@ func OperateQueue() error {
 		action = v1alpha1.CloseQueueAction
 	case ActionUpdate:
 		if operateQueueFlags.Weight == 0 {
-			return fmt.Errorf("When %s queue %s, weight must be specified, "+
+			return fmt.Errorf("when %s queue %s, weight must be specified, "+
 				"the value must be greater than 0", ActionUpdate, operateQueueFlags.Name)
 		}
 
@@ -89,9 +89,9 @@ func OperateQueue() error {
 
 		return err
 	case "":
-		return fmt.Errorf("Action can not be null")
+		return fmt.Errorf("action can not be null")
 	default:
-		return fmt.Errorf("Action %s invalid, valid actions are %s, %s and %s",
+		return fmt.Errorf("action %s invalid, valid actions are %s, %s and %s",
 			operateQueueFlags.Action, ActionOpen, ActionClose, ActionUpdate)
 	}
 

pkg/controllers/queue/queue_controller.go

@@ -298,7 +298,7 @@ func (c *Controller) handleCommand(cmd *busv1alpha1.Command) error {
 
 	err := c.vcClient.BusV1alpha1().Commands(cmd.Namespace).Delete(cmd.Name, nil)
 	if err != nil {
-		if true == apierrors.IsNotFound(err) {
+		if apierrors.IsNotFound(err) {
 			return nil
 		}
 

pkg/controllers/queue/state/closed.go

@@ -54,6 +54,4 @@ func (cs *closedState) Execute(action v1alpha1.Action) error {
 			return
 		})
 	}
-
-	return nil
 }

pkg/controllers/queue/state/closing.go

@@ -64,6 +64,4 @@ func (cs *closingState) Execute(action v1alpha1.Action) error {
 			return
 		})
 	}
-
-	return nil
 }

pkg/controllers/queue/state/open.go

@@ -64,6 +64,4 @@ func (os *openState) Execute(action v1alpha1.Action) error {
 			return
 		})
 	}
-
-	return nil
 }

test/e2e/job_controlled_resource.go

@@ -35,8 +35,7 @@ var _ = Describe("Job E2E Test: Test Job PVCs", func() {
 		ctx := initTestContext(options{})
 		defer cleanupTestContext(ctx)
 
-		var tt v12.HostPathType
-		tt = "DirectoryOrCreate"
+		var tt v12.HostPathType = "DirectoryOrCreate"
 
 		storageClsName := "standard"
 

test/e2e/job_plugins.go

@@ -206,7 +206,7 @@ var _ = Describe("Job E2E Test: Test Job Plugins", func() {
 		Expect(err).NotTo(HaveOccurred())
 
 		// Check whether network policy is created with job name
-		networkPolicyName := fmt.Sprintf("%s", jobName)
+		networkPolicyName := jobName
 		_, err = ctx.kubeclient.NetworkingV1().NetworkPolicies(ctx.namespace).Get(networkPolicyName, v1.GetOptions{})
 		// Error will occur because there is no policy should be created
 		Expect(err).To(HaveOccurred())