Fix/44 Add tests #53
Fix/44 Add tests #53
Conversation
|
/assign @william-wang |
|
/assign @Monokaix |
There was a problem hiding this comment.
The project does require tests and a testing framework, but this can be handled as a separate issue or as mentorship work for a mentee. The current state of the volcano dashboard still needs refinement and stabilization, which means testing is not the immediate priority. We also need to discuss which framework would be the best fit. In my opinion, we should revisit the testing aspect later.
|
You can rebase the master branch first: ) |
ok |
|
Hello @Monokaix, |
| @@ -76,6 +76,7 @@ const Layout = () => { | |||
| </AppBar> | |||
|
|
|||
| <Drawer | |||
| data-testid="sidebar-drawer" | |||
There was a problem hiding this comment.
id given to this component so that it is easier to get this while testing.
| // browser: { | ||
| // provider: "playwright", | ||
| // enabled: true, | ||
| // instances: [ | ||
| // { | ||
| // browser: "chromium", | ||
| // }, | ||
| // ], | ||
| // }, |
There was a problem hiding this comment.
This is useful when we want to run tests in the browser natively.
https://vitest.dev/guide/browser/
There was a problem hiding this comment.
Why comment this?
because this is Experimental feature.
|
Does this pr only add a test framework？And why choose vitest？ |
Yes, this adds the test framework Why VitestSince we are use |
|
Hey @Monokaix, rebased the PR, let me know if there's any other issue. |
|
Hello @Monokaix, What are your reviews on this? |
|
/lgtm |
|
Hi please rebase the master and keep one clean commit: ) |
Signed-off-by: Karan Yadav <xpresskaran98@gmail.com>
|
Hello @Monokaix, I have updated the commits, let me know if there's any other issue(s). :) |
| @@ -0,0 +1,12 @@ | |||
| import { defineConfig } from "vitest/config"; | |||
There was a problem hiding this comment.
We could have utilized Jest or Mocha for backend testing. However, we can postpone the testing phase for now, as there are still many progressive changes to be made in this PR #61
There was a problem hiding this comment.
Yeah you can keep working on that @de6p ！
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevin-wangzefeng, Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
Hey @Monokaix, Now we have to write tests. Should I create |
Maybe we can consider that: ) |
Describe the PR
In this PR, I have added the configuration files for writing tests in both frontend and backend. Using
Vitestas the testing framework.Resolves #44
How to test this PR