Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue8294: inherit k8s default volumeSnapshotClass #8721

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hu-keyu
Copy link

@hu-keyu hu-keyu commented Feb 25, 2025

Thank you for contributing to Velero!

Please add a summary of your change

Make compatible changes based on the GetVolumeSnapshotClassForStorageClass method,not break existing behaviour.

Does your change fix a particular issue?

Fixes #8294

Please indicate you've done the following:

@hu-keyu
Copy link
Author

hu-keyu commented Feb 25, 2025

review comments on PR 8719 has resovled,submit a new PR.

please reivew this PR @anshulahuja98

@hu-keyu
Copy link
Author

hu-keyu commented Feb 25, 2025

please review PR #8721 , thanks

@kaovilai
Copy link
Member

kaovilai commented Feb 25, 2025

@hu-keyu this might not merge until 1.16 release is cut FYI.
Also please fix your DCO
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants