Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle IO error on document save #961

Merged
merged 6 commits into from
Jan 19, 2022
Merged

Handle IO error on document save #961

merged 6 commits into from
Jan 19, 2022

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jan 11, 2022 •
edited
Loading

Summary:

The os.replace call in the document save function needs a try/except wrapper to ensure that it doesn't crash novelWriter in case of an error.

Related Issue(s):

Related to #960

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo mentioned this pull request Jan 11, 2022
Closed
@vkbo vkbo merged commit ec07ceb into main Jan 19, 2022
@vkbo vkbo deleted the save_file_error branch January 19, 2022 18:13
@vkbo vkbo added this to the Release 1.6 Beta 2 milestone Jan 20, 2022
@vkbo vkbo linked an issue Jan 20, 2022 that may be closed by this pull request
Crash when trying to create/open a project on Google Drive #960
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.6 RC 1
Development

Successfully merging this pull request may close these issues.

Crash when trying to create/open a project on Google Drive
1 participant
@vkbo