Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR rewrites how searches are run in the editor. All searches are run in advance, and the number of results are displayed on the search tool. Looping through search results is thus just a matter of iterating through the list.
This PR also changes how the "Scroll Past End" feature works in the editor. The old implementation changed the margin of the document root frame each time the document margins were updated. This is technically a change to the document, and therefore goes on the undo stack. This is triggered each time the search tool is opened, so it is a rather annoying side effect as it pollutes the undo stack. The feature has been rewritten to add a static margin on the document fram when the document is opened, and the undo stack is then cleared. The margin is a fixed number of lines, and is a user setting in Preferences.
Related Issue(s):
Resolves #645
Reviewer's Checklist: