Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve persistence of document search button state #1795

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Apr 4, 2024

Summary:

This PR drops the local caching of the document search options in the search widget class and instead relies on the config settings everywhere they're accessed, and lets the toggle buttons set the configs directly.

Related Issue(s):

Closes #1794

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.4 RC 1 milestone Apr 4, 2024
@vkbo vkbo linked an issue Apr 4, 2024 that may be closed by this pull request
@vkbo vkbo merged commit d0d6da3 into dev Apr 4, 2024
9 checks passed
@vkbo vkbo deleted the doc_search_updates branch April 4, 2024 21:33
@vkbo vkbo changed the title Improve state persistence of document search buttons Improve persistence of document search button state Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve document search toggle switch persistence
1 participant