Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GUI scaling #1788

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Improve GUI scaling #1788

merged 6 commits into from
Apr 1, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Apr 1, 2024

Summary:

This PR restructures how icons and buttons are created and fixes a number of issues where icons and buttons did not scale with GUI font size. The intention is that all buttons and icons should be relative to the selected GUI font size. This was mostly the case, but not everywhere. This PR also moves some of the calculations into helper classes to reduce code repetition where buttons and icons are added.

Related Issue(s):

Closes #1787

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.4 RC 1 milestone Apr 1, 2024
@vkbo vkbo linked an issue Apr 1, 2024 that may be closed by this pull request
@vkbo vkbo merged commit 3fb5d12 into dev Apr 1, 2024
9 checks passed
@vkbo vkbo deleted the font_scaling branch April 1, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make GUI scaling from font size consistent
1 participant