Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scene separator insertion after text #1716

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Remove scene separator insertion after text #1716

merged 2 commits into from
Feb 25, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Feb 25, 2024

Summary:

This PR changes the way scene separators are handled after encountering a text paragraph. Previously, any text would remove the blocker for inserting a scene separator. However, with the changes in #1711, only level 1 and 2 headers should block scene separator insertion. Text paragraphs should not affect it at all. Text inserted after a level 1 or 2 heading, followed by a leve 3 (scene) should flow uninterrupted.

Related Issue(s):

Related #1704

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.3 milestone Feb 25, 2024
@vkbo vkbo merged commit 5f79186 into main Feb 25, 2024
9 checks passed
@vkbo vkbo deleted the scene_separator branch February 25, 2024 21:56
@awqk
Copy link

awqk commented Mar 13, 2024

The non-existence of a text paragraph before the scene header should be enough to block scene headers/headings.

In my use case (short story), I do not want either level 1 or level 2 headers, because pandoc and the docx template already take care of title, author etc. The document is built from "standard markdown" build output, prefixed with a yaml metadata block.

Admittedly, this is nothing serious, only a minor annoyance.

@vkbo
Copy link
Owner Author

vkbo commented Mar 13, 2024

Posting this here under a merged pull request will do nothing as I cannot keep track of suggestions in closed and completed threads. Feel free to post a feature request instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants