Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix convert folders and open from outline #1306

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Fix convert folders and open from outline #1306

merged 3 commits into from
Jan 5, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jan 5, 2023

Summary:

This PR fixes two issues:

  • The convert to document/note menu entries in the project tree were still trying to convert files even if it was applied to a folder. They now properly call the convert folder function when used on folders.
  • Trying to open a document from outline view should switch focus even if the document is already open.

Related Issue(s):

Closes #1291
Closes #1305

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.0.3 milestone Jan 5, 2023
@vkbo vkbo changed the title Fix/convert and open Fix convert folders and open from outline Jan 5, 2023
@vkbo vkbo merged commit f6e5293 into patch Jan 5, 2023
@vkbo vkbo deleted the fix/convert_and_open branch January 5, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converting a folder does nothing Can't navigate back to currently open document from outline view
1 participant