Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updating highlighting prefs not updating editor #1278

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Fix updating highlighting prefs not updating editor #1278

merged 2 commits into from
Dec 1, 2022

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Dec 1, 2022 •
edited
Loading

Summary:

Changing the Preferences settings on the Highlighting tab did not trigger a reinitialisation of the editor and highlighter. This PR fixes that.

Related Issue(s):

Closes #1274

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.0.2 milestone Dec 1, 2022
@vkbo vkbo changed the title Fix updating highlighting pres not updating editor Fix updating highlighting prefs not updating editor Dec 1, 2022
@vkbo vkbo merged commit 1b177ff into patch Dec 1, 2022
@vkbo vkbo deleted the highlighter_settings branch December 1, 2022 22:24
@vkbo vkbo linked an issue Dec 1, 2022 that may be closed by this pull request
Syntax highlighter not updated when settings change #1274
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.0.2
Development

Successfully merging this pull request may close these issues.

Syntax highlighter not updated when settings change
1 participant
@vkbo