Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.1 regression] ModuleNotFoundError: No module named 'novelwriter.gui' #1277

Closed
yurivict opened this issue Dec 1, 2022 · 11 comments · Fixed by #1279
Closed

[2.0.1 regression] ModuleNotFoundError: No module named 'novelwriter.gui' #1277

yurivict opened this issue Dec 1, 2022 · 11 comments · Fixed by #1279
Assignees
Labels
installation Issue: Problem when installing
Milestone

Comments

@yurivict
Copy link

yurivict commented Dec 1, 2022

$ novelwriter
Traceback (most recent call last):
  File "/usr/local/bin/novelwriter", line 33, in <module>
    sys.exit(load_entry_point('novelWriter==2.0.1', 'gui_scripts', 'novelwriter')())
  File "/usr/local/lib/python3.9/site-packages/novelwriter/__init__.py", line 239, in main
    from novelwriter.guimain import GuiMain
  File "/usr/local/lib/python3.9/site-packages/novelwriter/guimain.py", line 41, in <module>
    from novelwriter.gui.theme import GuiTheme
ModuleNotFoundError: No module named 'novelwriter.gui'
@yurivict yurivict added the bug Issue: Something isn't working label Dec 1, 2022
@vkbo
Copy link
Owner

vkbo commented Dec 1, 2022

Eh, I just fixed that in #1272. How did you install it?

Edit: Duplicate of #1273

@yurivict
Copy link
Author

yurivict commented Dec 1, 2022

How did you install it?

FreeBSD port.

@vkbo
Copy link
Owner

vkbo commented Dec 1, 2022

All the Linux packages in the release had this error, but they have been updated both here and on PyPi and Launchpad. I don't manage the FreeBSD port. It is probably still using the broken version.

@vkbo
Copy link
Owner

vkbo commented Dec 1, 2022

Ah, wait, that's you, right? I can make a new tag if that helps. There was no need for the other releases as it was enough to make a new build.

@vkbo
Copy link
Owner

vkbo commented Dec 1, 2022

I initially removed the __init__.py files in all subfolders and instead used direct imports everywhere to avoid repeated issues with circular imports. However, the setuptools build then proceeded to ignore all those folders, so I added back empty ones and rebuilt the wheel and deb files. They only got a build number bump though. I didn't do a full new release.

If that doesn't work with the port, please let me know if there is anything I can do to fix it. Preferably without having to do a full new release. Will a 2.0.1-post1 tag do the trick?

@vkbo vkbo added installation Issue: Problem when installing and removed bug Issue: Something isn't working labels Dec 1, 2022
@vkbo vkbo self-assigned this Dec 1, 2022
@yurivict
Copy link
Author

yurivict commented Dec 1, 2022

Does the latest release include the fix?

@vkbo
Copy link
Owner

vkbo commented Dec 1, 2022

No, I just added the dummy files and rebuilt those specific packages. The files were merged after the tag. Commit 347266a9bdf06ae65fef558c0918a2dfa6a84a49 will build.

@vkbo
Copy link
Owner

vkbo commented Dec 1, 2022

Does the port pull release tags? It would be useful to know so I can avoid breaking it in the future. I was only considering the PyPi and Launchpad packages here as they both have mechanisms for dealing with this without a new release.

I can also just make the 2.0.2 release. There is also bug #1274 that needs fixing. It will take me about an hour.

@yurivict
Copy link
Author

yurivict commented Dec 1, 2022

FreeBSD ports can read individual tags and revisions.
But they are usually updated based on new release tags.

@vkbo
Copy link
Owner

vkbo commented Dec 1, 2022

Ok, good to know. I will keep this in mind. I just fixed #1274, so I can make a new release. That bug annoyed me anyway.

@vkbo vkbo added this to the Release 2.0.2 milestone Dec 1, 2022
@vkbo vkbo mentioned this issue Dec 1, 2022
6 tasks
@vkbo vkbo linked a pull request Dec 1, 2022 that will close this issue
6 tasks
@yurivict
Copy link
Author

yurivict commented Dec 1, 2022

2.0.2 works. Thank you.

@yurivict yurivict closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Issue: Problem when installing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants