More unsigned/signed compare fixes

Author: igorcanadi

Makefile

@@ -181,6 +181,10 @@ release:
 	$(MAKE) clean
 	OPT="-DNDEBUG -O2" $(MAKE) static_lib $(PROGRAMS) -j32
 
+release_shared_lib:
+	$(MAKE) clean
+	OPT="-DNDEBUG -O2" $(MAKE) shared_lib -j32
+
 coverage:
 	$(MAKE) clean
 	COVERAGEFLAGS="-fprofile-arcs -ftest-coverage" LDFLAGS+="-lgcov" $(MAKE) all check -j32

db/column_family_test.cc

@@ -934,7 +934,7 @@ TEST(ColumnFamilyTest, DontRollEmptyLogs) {
   }
   int total_new_writable_files =
       env_->GetNumberOfNewWritableFileCalls() - num_writable_file_start;
-  ASSERT_EQ(total_new_writable_files, handles_.size() + 1);
+  ASSERT_EQ(static_cast<size_t>(total_new_writable_files), handles_.size() + 1);
   Close();
 }
 

db/db_test.cc

@@ -5735,10 +5735,10 @@ TEST(DBTest, ReadFirstRecordCache) {
 
   SequenceNumber s;
   ASSERT_OK(dbfull()->TEST_ReadFirstLine(path, &s));
-  ASSERT_EQ(s, 0);
+  ASSERT_EQ(s, 0U);
 
   ASSERT_OK(dbfull()->TEST_ReadFirstRecord(kAliveLogFile, 1, &s));
-  ASSERT_EQ(s, 0);
+  ASSERT_EQ(s, 0U);
 
   log::Writer writer(std::move(file));
   WriteBatch batch;
@@ -5751,12 +5751,12 @@ TEST(DBTest, ReadFirstRecordCache) {
   ASSERT_EQ(env_->sequential_read_counter_.Read(), 0);
 
   ASSERT_OK(dbfull()->TEST_ReadFirstRecord(kAliveLogFile, 1, &s));
-  ASSERT_EQ(s, 10);
+  ASSERT_EQ(s, 10U);
   // did a read
   ASSERT_EQ(env_->sequential_read_counter_.Read(), 1);
 
   ASSERT_OK(dbfull()->TEST_ReadFirstRecord(kAliveLogFile, 1, &s));
-  ASSERT_EQ(s, 10);
+  ASSERT_EQ(s, 10U);
   // no new reads since the value is cached
   ASSERT_EQ(env_->sequential_read_counter_.Read(), 1);
 }