Skip to content

Commit e41c060

Browse files
committed
Make sure logger is safely released in InfoLogLevel
Summary: fix the memory leak that was captured by jenkin build. Test Plan: ran the valgrind test locally Reviewers: yhchiang CC: leveldb Differential Revision: https://reviews.facebook.net/D16389
1 parent 444cafc commit e41c060

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

util/auto_roll_logger_test.cc

+3-2
Original file line numberDiff line numberDiff line change
@@ -244,8 +244,9 @@ TEST(AutoRollLoggerTest, InfoLogLevel) {
244244
const int kInfoLogLevelNameLens[5] = {5, 4, 4, 5, 5};
245245

246246
size_t log_size = 8192;
247-
AutoRollLogger* logger =
248-
new AutoRollLogger(Env::Default(), kTestDir, "", log_size, 0);
247+
std::unique_ptr<AutoRollLogger> logger_guard(
248+
new AutoRollLogger(Env::Default(), kTestDir, "", log_size, 0));
249+
auto logger = logger_guard.get();
249250

250251
int message_length = kSampleMessage.length();
251252
int log_length = 0;

0 commit comments

Comments
 (0)