Skip to content

Commit d045846

Browse files
committed
Add google-style checker to "arc lint"
Summary: After we reached a consensus on code format, which follows exactly Google's coding style, a natural follow-up is to have a style checker that can handle stuffs beyond format. Google already has a powerful style checker "cpplint.py" and, luckily, phabricator already provides the built-in linter for it! Next time with "arc lint" most style inconsistency will be detected (but will not be fixed). Also I copied cpplint.py to linters directory, which is mostly because we may need the flexibility to make some modifications on it for our own need. Test Plan: ran arc lint table/block_based_table_builder.cc to see the amazing results. Reviewers: haobo, sdong, igor, dhruba Reviewed By: haobo CC: leveldb Differential Revision: https://reviews.facebook.net/D15369
1 parent fb01755 commit d045846

9 files changed

+4779
-19
lines changed

.arcconfig

+5-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
{
2-
"project_id" : "leveldb",
2+
"project_id" : "rocksdb",
33
"conduit_uri" : "https://reviews.facebook.net/",
4-
"copyright_holder" : "",
4+
"copyright_holder" : "Facebook",
55
"load" : [
6-
"linters/src/"
6+
"linters"
77
],
88
"lint.engine" : "FacebookFbcodeLintEngine",
9-
"lint.engine.single.linter" : "FbcodeCppLinter"
9+
"lint.engine.single.linter" : "FbcodeCppLinter",
10+
"lint.cpplint.prefix" : "linters"
1011
}

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,4 @@ util/build_version.cc
2020
build_tools/VALGRIND_LOGS/
2121
coverage/COVERAGE_REPORT
2222
.gdbhistory
23+
.phutil_module_cache
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)