Skip to content

Commit b2e7ee8

Browse files
author
Kai Liu
committed
Followup code refactor on plain table
Summary: Fixed most comments in https://reviews.facebook.net/D15429. Still have some remaining comments left. Test Plan: make all check Reviewers: sdong, haobo Reviewed By: haobo CC: leveldb Differential Revision: https://reviews.facebook.net/D15885
1 parent 85c0545 commit b2e7ee8

4 files changed

+139
-131
lines changed

db/plain_table_db_test.cc

+3-5
Original file line numberDiff line numberDiff line change
@@ -190,12 +190,10 @@ class TestPlainTableReader : public PlainTableReader {
190190
const TableProperties* table_properties,
191191
unique_ptr<RandomAccessFile>&& file,
192192
const Options& options, bool* expect_bloom_not_match)
193-
: PlainTableReader(storage_options, icomparator, file_size,
194-
bloom_bits_per_key, hash_table_ratio, index_sparseness,
195-
table_properties),
193+
: PlainTableReader(options, std::move(file), storage_options, icomparator,
194+
file_size, bloom_bits_per_key, hash_table_ratio,
195+
index_sparseness, table_properties),
196196
expect_bloom_not_match_(expect_bloom_not_match) {
197-
file_ = std::move(file);
198-
options_ = options;
199197
Status s = PopulateIndex();
200198
ASSERT_TRUE(s.ok());
201199
}

0 commit comments

Comments
 (0)