Skip to content

Commit 9db8c4c

Browse files
committed
Fix share_table_files bug
Summary: constructor wasn't properly constructing BackupableDBOptions Test Plan: no test Reviewers: benj Reviewed By: benj CC: leveldb Differential Revision: https://reviews.facebook.net/D16749
1 parent fac58c0 commit 9db8c4c

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

include/utilities/backupable_db.h

+1
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ struct BackupableDBOptions {
6464
bool _destroy_old_data = false)
6565
: backup_dir(_backup_dir),
6666
backup_env(_backup_env),
67+
share_table_files(_share_table_files),
6768
info_log(_info_log),
6869
sync(_sync),
6970
destroy_old_data(_destroy_old_data) {}

utilities/backupable/backupable_db.cc

+5-3
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,12 @@ namespace rocksdb {
2929
void BackupableDBOptions::Dump(Logger* logger) const {
3030
Log(logger, " Options.backup_dir: %s", backup_dir.c_str());
3131
Log(logger, " Options.backup_env: %p", backup_env);
32-
Log(logger, "Options.share_table_files: %d", share_table_files);
32+
Log(logger, "Options.share_table_files: %d",
33+
static_cast<int>(share_table_files));
3334
Log(logger, " Options.info_log: %p", info_log);
34-
Log(logger, " Options.sync: %d", sync);
35-
Log(logger, " Options.destroy_old_data: %d", destroy_old_data);
35+
Log(logger, " Options.sync: %d", static_cast<int>(sync));
36+
Log(logger, " Options.destroy_old_data: %d",
37+
static_cast<int>(destroy_old_data));
3638
}
3739

3840
// -------- BackupEngineImpl class ---------

0 commit comments

Comments
 (0)