[RocksDB Performance Branch] Fix a regression bug of munmap

siying · siying · commit 8aac46d6864d · 2013-11-26T14:05:37.000-08:00
Summary: Fix a stupid bug I just introduced in b59d4d5, which I didn't even mean to include. GCC might remove the munmap. Test Plan: Run it and make sure munmap succeeds Reviewers: haobo, kailiu Reviewed By: kailiu CC: dhruba, reconnect.grayhat, leveldb Differential Revision: https://reviews.facebook.net/D14361
diff --git a/util/env_posix.cc b/util/env_posix.cc
@@ -307,7 +307,11 @@ class PosixMmapReadableFile: public RandomAccessFile {
     assert(options.use_os_buffer);
   }
   virtual ~PosixMmapReadableFile() {
-    assert(munmap(mmapped_region_, length_) == 0);
+    int ret = munmap(mmapped_region_, length_);
+    if (ret != 0) {
+      fprintf(stdout, "failed to munmap %p length %zu \n",
+              mmapped_region_, length_);
+    }
   }
 
   virtual Status Read(uint64_t offset, size_t n, Slice* result,

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,11 @@ class PosixMmapReadableFile: public RandomAccessFile {`
`307`	`307`	`assert(options.use_os_buffer);`
`308`	`308`	`}`
`309`	`309`	`virtual ~PosixMmapReadableFile() {`
`310`		`- assert(munmap(mmapped_region_, length_) == 0);`
	`310`	`+ int ret = munmap(mmapped_region_, length_);`
	`311`	`+ if (ret != 0) {`
	`312`	`+ fprintf(stdout, "failed to munmap %p length %zu \n",`
	`313`	`+ mmapped_region_, length_);`
	`314`	`+ }`
`311`	`315`	`}`
`312`	`316`
`313`	`317`	`virtual Status Read(uint64_t offset, size_t n, Slice* result,`