Skip to content

Commit 5f1daf7

Browse files
author
Lei Jin
committed
get rid of shared_ptr in memtable.cc
Summary: Get rid of the devil. Probably won't impact anything on the perf side. Test Plan: make all check Reviewers: igor, haobo, sdong, yhchiang Reviewed By: haobo CC: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D18153
1 parent 547bb6a commit 5f1daf7

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

db/memtable.cc

+2-3
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,6 @@ class MemTableIterator: public Iterator {
162162
MemTableIterator(const MemTable& mem, const ReadOptions& options)
163163
: bloom_(nullptr),
164164
prefix_extractor_(mem.prefix_extractor_),
165-
iter_(),
166165
valid_(false) {
167166
if (options.prefix) {
168167
iter_.reset(mem.table_->GetPrefixIterator(*options.prefix));
@@ -217,7 +216,7 @@ class MemTableIterator: public Iterator {
217216
private:
218217
DynamicBloom* bloom_;
219218
const SliceTransform* const prefix_extractor_;
220-
std::shared_ptr<MemTableRep::Iterator> iter_;
219+
std::unique_ptr<MemTableRep::Iterator> iter_;
221220
bool valid_;
222221

223222
// No copying allowed
@@ -477,7 +476,7 @@ bool MemTable::UpdateCallback(SequenceNumber seq,
477476
LookupKey lkey(key, seq);
478477
Slice memkey = lkey.memtable_key();
479478

480-
std::shared_ptr<MemTableRep::Iterator> iter(
479+
std::unique_ptr<MemTableRep::Iterator> iter(
481480
table_->GetIterator(lkey.user_key()));
482481
iter->Seek(lkey.internal_key(), memkey.data());
483482

0 commit comments

Comments
 (0)