Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full screen icon is not working on Safari 5.0.5 #688

Closed
DanyaMassadeh opened this issue Aug 15, 2013 · 6 comments
Closed

Full screen icon is not working on Safari 5.0.5 #688

DanyaMassadeh opened this issue Aug 15, 2013 · 6 comments

Comments

@DanyaMassadeh
Copy link

I got this error when click on fullscreen icon:

Error: The "enterfullscreen" method is not available on the playback technology's API

I am using Safari 5.0.5.

Thanks for help.

@heff
Copy link
Member

heff commented Aug 19, 2013

I can't reproduce this. Is there a live page somewhere I can see this happening?

@DanyaMassadeh
Copy link
Author

I test the video in the videojs.com home page, same error.

The button simply is not working and you can see the error in the developing tool for safari.

I am using safari 5.0.5 and Mac OS X 10.6.8

Really appreciate your help.

@DanyaMassadeh
Copy link
Author

OK I found the issue, I did a try with the video.dev.js and it is working, the problem with the minification js version.

@heff
Copy link
Member

heff commented Aug 20, 2013

Ah, that makes sense. Thanks for digging into that. We need to export enterFullScreen and exitFullScreen here:
https://github.com/videojs/video.js/blob/master/src/js/exports.js#L121

Should be an easy pull request. Do you want to give it a shot and get contributor credit?

@DanyaMassadeh
Copy link
Author

So just add
goog.exportProperty(vjs.Html5.prototype, 'enterFullScreen', vjs.Html5.prototype.setLoop);
goog.exportProperty(vjs.Html5.prototype, 'exitFullScreen', vjs.Html5.prototype.setLoop);

?????

@heff
Copy link
Member

heff commented Oct 8, 2013

You would also need to change the setLoop part. (sorry for the slow response)

goog.exportProperty(vjs.Html5.prototype, 'enterFullScreen', vjs.Html5.prototype.enterFullScreen);
goog.exportProperty(vjs.Html5.prototype, 'exitFullScreen', vjs.Html5.prototype.exitFullScreen);

@heff heff closed this as completed in d0f8b3e Feb 3, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants