fix(text track display): update on playerresize and orientationchange #5447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
previously requested changes
Sep 25, 2018
src/js/tracks/text-track-display.js
Outdated
| player.on('playerresize', updateDisplayHandler); | ||
|
|
||
| window.addEventListener('orientationchange', updateDisplayHandler); | ||
| player.on('dipose', () => window.removeEventListener('orientationchange', updateDisplayHandler)); |
There was a problem hiding this comment.
It's even a typo of depose, ugh
|
Can be verified here: https://deploy-preview-5447--videojs-docs.netlify.com/test-example/ |
|
QA LGTM |
brandonocasey
approved these changes
Sep 25, 2018
gkatsev
added a commit
that referenced
this pull request
Oct 31, 2018
…#5447) On mobile devices, when changing orientation, or if the player gets resized, the captions won't update to reflect the new orientation or player size. However, they do get updated the next time they are redrawn. Instead, we should redraw the captions whenever `orientationchange` and `playerresize` get triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mobile devices, when changing orientation, or if the player gets resized, the captions won't update to reflect the new orientation or player size. However, they do get updated the next time they are redrawn. Instead, we should redraw the captions whenever
orientationchangeandplayerresizeget triggered.