Add: Notes on Webpack Fixes in React Docs #4261
Conversation
Note how to require the css file, as denoted in the FAQ sections and clarification on how to resolve the .eot files in the css file.
|
Thanks @MCDELTAT, I wonder though if we should move it to a separate |
|
Sure. I'll do that later today. |
|
In addition to the fixes already in place I also figured out how to use videojs-contrib-hls in te same setup. Should I create a webpack document there about the subject or combine all webpack related fixes in one doc? |
Removed references to Webpack from the React guide and moved them to a new Webpack guide. It also adds help on the configuration needed to use videojs-contrib-hls with Webpack.
Now refferences the new Webpack guide, alphabetized the links at the bottom for ease of future revision.
|
Keeping it here for contrib-hls is probably fine, though, we'd probably want to document it for HLS as well. Also, is the change at the bottom of the FAQ just sorting of the links? |
docs/guides/webpack.md
Outdated
| @@ -0,0 +1,37 @@ | |||
| # Using Webpack with Video.js | |||
|
|
|||
| video.js, and the playback technologies such as videojs-contrib-hls all work in a Webpack based build environment. Here are several configuration changes specific to Webpack that will get you up and running. The following guide was written and tested for videojs v15.9.1 and videojs-contrib-hls v5.4.0 | |||
There was a problem hiding this comment.
I'm not sure it's necessary to specify the versions used. It should work with all versions
docs/guides/webpack.md
Outdated
|
|
||
| video.js, and the playback technologies such as videojs-contrib-hls all work in a Webpack based build environment. Here are several configuration changes specific to Webpack that will get you up and running. The following guide was written and tested for videojs v15.9.1 and videojs-contrib-hls v5.4.0 | ||
|
|
||
| ### Video.js CSS: |
There was a problem hiding this comment.
these headings should be ##, but I can always change that before merging.
|
Ok. Yes the bottom of the page is just sorting the links alphabetically. I guess my OCD kicked in. I took the time to verify all the links still worked as well. I'll change those to ## right now. I think I left the versions in just because contrib-hls states that you need to add videojs-flash as well if you use v6.0. I can remove that if you want as well. |
This removes refferences to versions that this guide was tested on, and changes the header sizes from ### to ##.
|
Heh, it's fine. Just took me a while to figure out what was going on and wanted confirmation :D |
Note how to require the css file, as denoted in the FAQ sections and clarification on how to resolve the .eot files in the css file.