Update xhr to the latest version 🚀 #4101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.4.0 of xhr just got published.
The version 2.4.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of xhr.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 15 commits .
a7b4344
2.4.0
1434957
remove accidental timeouts in tests
085fc6b
assert abort tests are successful not only because xhr callback was run asynchronously
9f60a89
Merge pull request #153 from stuartsan/ensure-callback-not-called-on-abort
f01681f
fix mock server to be more readable
54988ff
switching the controversial test back to try-catch as error is (a)synchronous in different browsers
7dc4abf
Merge pull request #152 from naugtur/fix-151-more-nocontent-in-ff
f2b1784
Use timeout endpoint to simulate more realistic response time
d3ecab5
Test: trigger CI
5915c3a
Add test for async abort
879ecb7
Ensure callback not called on abort
0b9ba05
generalize FF fix to 2xx
8913fac
fix #151 - add exception for FF for 201 202 204 205 codes
82b507c
Fix #148 - add timeouts to tests to prevent them from hanging when errors break assert.end
b05c405
update personal information
See the full diff.
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴