Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MuteToggle.controlText when volume set to 0 #4056

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Fix MuteToggle.controlText when volume set to 0 #4056

merged 1 commit into from
Feb 15, 2017

Conversation

kevinlitchfield
Copy link
Contributor

Because MuteToggle.controlText is coordinated only with muted and not with volume, it doesn't change when volume is set to zero:

feb-10-2017 13-42-02

This fixes by adding a check for this.player_.volume() === 0 to the predicate of the conditional that sets toMute.

@OwenEdwards OwenEdwards mentioned this pull request Feb 11, 2017
Closed
@brandonocasey brandonocasey merged commit 3c1108c into videojs:master Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

@brandonocasey brandonocasey brandonocasey approved these changes

Assignees
No one assigned
Labels
confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinlitchfield @gkatsev @brandonocasey