Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update es.json #3984

Merged
merged 3 commits into from
Feb 3, 2017
Merged

Update es.json #3984

merged 3 commits into from
Feb 3, 2017

Conversation

RevinKey
Copy link
Contributor

@RevinKey RevinKey commented Jan 26, 2017

translations-needed.txt

Description

Added "Play Video" for BigPlayButton's ControlText

Specific Changes proposed

Added "Play Video": "Reproducción Vídeo", to the es language JSON

Requirements Checklist

  • Feature implemented
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Added "Play Video" for BigPlaybutton's ControlText
@brandonocasey
Copy link
Contributor

Thanks for the PR @RevinKey! Are you able to run the grunt check-translations task to update translations-needed.md? Your PR looks good other than that.

@RevinKey
Copy link
Contributor Author

RevinKey commented Jan 26, 2017

@brandonocasey I am able to run grunt check-translations locally and I see the change. Not sure what is required from there

@mister-ben
Copy link
Contributor

After you've run the task, just add the updated translations-needed.md to the PR. Thanks

@gkatsev
Copy link
Member

gkatsev commented Feb 2, 2017

@RevinKey any updates? Thanks!

@RevinKey
Copy link
Contributor Author

RevinKey commented Feb 3, 2017

Sorry for delay, it is updated now

@gkatsev gkatsev merged commit 70d2eb1 into videojs:master Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants