Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/accessible volume control #3957

Merged
merged 16 commits into from
Jan 19, 2017
Merged

Feature/accessible volume control #3957

merged 16 commits into from
Jan 19, 2017

Conversation

brandonocasey
Copy link
Contributor

Description

Separate VolumeBar and MuteToggle from VolumeMenuButton and make it accessible.

Specific Changes proposed

  • Remove VolumeMenuButton
  • Add MuteToggle to ControlBar
  • Add VolumeControl to ControlBar
  • Make VolumeControl Work with VolumeBar
  • Make VolumeControl Work with MuteToggle
  • Verify Accessibility

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser
      • Chome /w Voiceover on OSX
      • Firefox /w Voiceover on OSX
      • Safari /w Voiceover on OSX
      • Edge /w JAWS
      • IE 11 /w JAWS
      • IE 10 /w JAWS
      • IE 9 /w JAWS
      • IE 8 /w JAWS
  • Reviewed by Two Core Contributors

@brandonocasey brandonocasey mentioned this pull request Jan 19, 2017
Closed
12 tasks
@gkatsev gkatsev merged commit 524f868 into master Jan 19, 2017
@gkatsev gkatsev deleted the feature/accessible-volume-control branch January 19, 2017 20:54
@brandonocasey brandonocasey mentioned this pull request Jan 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonocasey @gkatsev