Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show big play button on pause if specified #3892

Merged
merged 2 commits into from
Jan 3, 2017
Merged

Show big play button on pause if specified #3892

merged 2 commits into from
Jan 3, 2017

Conversation

geibi
Copy link
Contributor

@geibi geibi commented Dec 23, 2016 •
edited by mmcc
Loading

Show big play button if video is paused and
.vjs-show-big-play-button-on-pause is set on video element

Description

If you pause a video-js video, the play button isn't shown like most users expect from UIs like youbtube or iPhone video behavior.
This patch implements a play button after pause if needed via an additional CSS class on the video-js video elemetn.

Specific Changes proposed

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

geibi and others added 2 commits December 23, 2016 22:37
@geibi
Show big play button on pause if specified
824793f 
Show big play button if video is paused and
.vjs-show-big-play-button-on-pause is set on video element
@gkatsev
style change
b7347d7
gkatsev
gkatsev approved these changes Dec 29, 2016
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems a small enough change and easy to support.

I made a small commit to add a space before the curly brace.

@gkatsev gkatsev added minor This PR can be added to a minor release. It should not be added to a patch release. confirmed labels Dec 30, 2016
misteroneill
misteroneill approved these changes Jan 3, 2017
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me.

@gkatsev gkatsev merged commit b547214 into videojs:master Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
confirmed minor This PR can be added to a minor release. It should not be added to a patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geibi @misteroneill @gkatsev