We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Now that #2391 / #2425 is merged into master, it breaks disposing the player element in at least IE9 and IE10.
I think this is because those do not support native text tracks and the code removes event listeners on those elements.
See http://jsbin.com/tilobifaza/edit?html,output for a JSBin that fails in those browsers.
The text was updated successfully, but these errors were encountered:
You're right. We need to do a null check before trying to remove or add the event listeners. Mind putting a PR for that?
Sorry, something went wrong.
Looks like this is causing issues in our CI. I'll take that on now.
Now that #2466 is merged in, can we verify if this can be close?
I already applied it manually yesterday and my tests passed, so this can indeed be closed.
Great! Thanks @nickygerritsen.
gkatsev
Successfully merging a pull request may close this issue.
Now that #2391 / #2425 is merged into master, it breaks disposing the player element in at least IE9 and IE10.
I think this is because those do not support native text tracks and the code removes event listeners on those elements.
See http://jsbin.com/tilobifaza/edit?html,output for a JSBin that fails in those browsers.
The text was updated successfully, but these errors were encountered: