Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #2391 / #2425 break dispose when no native tt is supported #2454

Closed
nickygerritsen opened this issue Aug 10, 2015 · 5 comments
Closed

PR #2391 / #2425 break dispose when no native tt is supported #2454

nickygerritsen opened this issue Aug 10, 2015 · 5 comments
Assignees
Milestone

Comments

@nickygerritsen
Copy link

Now that #2391 / #2425 is merged into master, it breaks disposing the player element in at least IE9 and IE10.

I think this is because those do not support native text tracks and the code removes event listeners on those elements.

See http://jsbin.com/tilobifaza/edit?html,output for a JSBin that fails in those browsers.

@gkatsev
Copy link
Member

gkatsev commented Aug 10, 2015

You're right. We need to do a null check before trying to remove or add the event listeners. Mind putting a PR for that?

@gkatsev gkatsev added this to the Text Tracks milestone Aug 10, 2015
@gkatsev
Copy link
Member

gkatsev commented Aug 10, 2015

Looks like this is causing issues in our CI. I'll take that on now.

@heff
Copy link
Member

heff commented Aug 12, 2015

Now that #2466 is merged in, can we verify if this can be close?

@nickygerritsen
Copy link
Author

I already applied it manually yesterday and my tests passed, so this can indeed be closed.

@heff
Copy link
Member

heff commented Aug 13, 2015

Great! Thanks @nickygerritsen.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants