Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot obtain original video dimensions in IE8 #1824

Closed
bewards opened this issue Jan 23, 2015 · 3 comments
Closed

Cannot obtain original video dimensions in IE8 #1824

bewards opened this issue Jan 23, 2015 · 3 comments

Comments

@bewards
Copy link

bewards commented Jan 23, 2015

I've gotten VideoJS to be responsive with just CSS in every browser besides IE8. And so my work around was to obtain the aspect ratio of the video to set the height accordingly. It seems that, in IE8 (also using html5shiv), getting the original dimensions of the video are not possible, as it defaults back to 300x150. This may not be a bug, as this is a SWF fallback inside a html5 video container, but I'd like to confirm if this is correct? If not possible, it seems the only work around would be to give a static aspect ratio.

@mmcc
Copy link
Member

mmcc commented Jan 23, 2015

There's a pretty long thread about responsive sizing, and basically the tl;dr is yes, you have to specify the aspect ratio going in (at least that's what we've come up with so far). If you have any additional feedback, feel free to comment there: #982.

@mmcc mmcc closed this as completed Jan 23, 2015
@bewards
Copy link
Author

bewards commented Jan 23, 2015

Thanks for the very quick response, I'm a big fan of this ongoing video work. I actually based the responsive off that thread. I'll contribute to it if my approach has a better support range.

@mmcc
Copy link
Member

mmcc commented Jan 23, 2015

Excellent! That would be much appreciated.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants