fix(cues): only copy cue props that don't exist (#4146)

videojs · Mar 2, 2017 · de08669 · de08669
1 parent 5c3be8b
commit de08669
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/js/tracks/text-track.js b/src/js/tracks/text-track.js
@@ -335,7 +335,9 @@ class TextTrack extends Track {
       cue = new window.vttjs.VTTCue(originalCue.startTime, originalCue.endTime, originalCue.text);
 
       for (const prop in originalCue) {
-        cue[prop] = originalCue[prop];
+        if (!(prop in cue)) {
+          cue[prop] = originalCue[prop];
+        }
       }
     }
 

diff --git a/test/unit/tracks/text-track.test.js b/test/unit/tracks/text-track.test.js
@@ -16,7 +16,17 @@ const defaultTech = {
   currentTime() {}
 };
 
-QUnit.module('Text Track');
+QUnit.module('Text Track', {
+  beforeEach() {
+    this.oldVttjs = window.vttjs;
+    window.vttjs = {
+      VTTCue: Object
+    };
+  },
+  afterEach() {
+    window.vttjs = this.oldVttjs;
+  }
+});
 
 // do baseline track testing
 TrackBaseline(TextTrack, {