Skip to content

Commit

Permalink
fix(sass): import path no longer has cwd (#4001)
Browse files Browse the repository at this point in the history 
node-sass updated to remove the cwd from import paths.

Fix #3998
  • Loading branch information
@gkatsev
gkatsev authored Jan 31, 2017
1 parent c8f5e3a commit 19b429b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/css/video-js.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@import "private-variables";
@import "utilities";

@import "node_modules/videojs-font/scss/icons";
@import "../../node_modules/videojs-font/scss/icons";

@import "components/layout";
@import "components/big-play";
Expand Down

3 comments on commit 19b429b

@OwenEdwards
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this needs to be back-ported into the 5.x branch?

@gkatsev
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably.

@wells
Copy link
Contributor

@wells wells commented on 19b429b Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks for me.

It works with these two possibilities:

  • @import "node_modules/videojs-font/scss/icons";
  • @import "../../../node_modules/videojs-font/scss/icons";

Please sign in to comment.