Skip to content

Commit

Permalink
Make track settings dialog modal
Browse files Browse the repository at this point in the history
This is the only way to get the correct role=dialog on it. Otherwise it
always has role=tooltip and we can't change it. See https://github.com/yjose/reactjs-popup/blob/4d8e41a5995ba5074c0133bf0901bf0f93805616/src/index.tsx#L280 and yjose/reactjs-popup#334
  • Loading branch information
adamnovak committed Mar 28, 2023
1 parent 44220c7 commit 99e18a2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/components/TrackSettingsButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const TrackSettingsButton = ({
availableColors
}) => {
return(
<Popup trigger={<button type="button"> Settings </button>} position="right center">
<Popup trigger={<button type="button"> Settings </button>} position="right center" modal>
<TrackSettings
fileType={fileType}
trackColorSettings={trackColorSettings}
Expand Down

0 comments on commit 99e18a2

Please sign in to comment.