Fix autoscaler bug #913
Merged
Fix autoscaler bug #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchen-vertica
approved these changes
Sep 4, 2024
|
So the issue is: the customer is using v1 vdb, but v1beta1.vdb will convert vdb to v1beta1 version with wrong values. We probably need to fix the v1-v1beta1 conversion function in a follow-up jira. |
|
No, the conversion logic is fine. The issue is that verticaautoscaler reconcilers were outdated, still using v1beta1 vdb to cache vdb info. So when you try to convert back from v1beta1 to v1, the absence of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a VerticaAutoscaler on a VerticaDB where
vcluster-opswas not explicitly set totruewe hit aCreateContainerErrorerror. This happens because the autoscaler was still internally using a v1beta1 VerticaDB which led to the conversion webhook wrongfully setting that annotation tofalse.This fixes the issue by using a v1 VerticaDB instead.
Closes #908