Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of GSM for superuser password secret #474

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

sivaalamp
Copy link
Contributor

@sivaalamp sivaalamp commented Jul 31, 2023

This is similar to #458 except we read from GSM for the superuser password secret. We use the same feature flag as before. Here is a sample CR to enable it.

kind: VerticaDB
metadata:
  name: v
  annotations:
    vertica.com/use-gcp-secret-manager: "true" 
spec:
  superuserPasswordSecret: <full name of the secret in GSM>
...

The name of the GSM secret is taken from the existing spec.superuserPasswordSecret field.

Note, if GSM is being used we can't use the canary query for health probes as that depends on the superuser password being a k8s secret. Instead, we check if vertica is running by seeing if anyone is listening on the vertica client port.

@spilchen spilchen changed the title Updates for VER-88221: Enable use of GSM for superuser password secret Allow use of GSM for superuser password secret Jul 31, 2023
@spilchen
Copy link
Collaborator

@sivaalamp thanks for your contribution. I don't normally do this, but since we are short on time I opted to apply the code review comments myself. This will shorten the review cycle and allow us to get it in QA hands sooner.

@spilchen spilchen merged commit a4c8c88 into vertica:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants