Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade operator-sdk to 1.28.0 #365

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Conversation

roypaulin
Copy link
Collaborator

Changes reflect migration steps as outlined here:
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.28.0/

prior version was v1.25.2

Go version moved to 1.19.6
golanci-lint version moved to 1.51.1

@roypaulin roypaulin requested a review from spilchen April 4, 2023 15:37
Copy link
Collaborator

@spilchen spilchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments...

@@ -31,7 +31,7 @@ image:

rbac_proxy_image:
repo: gcr.io
name: kubebuilder/kube-rbac-proxy:v0.13.0
name: kubebuilder/kube-rbac-proxy:v0.13.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an update missing in tests/external-images-common-ci.txt

@spilchen
Copy link
Collaborator

spilchen commented Apr 4, 2023

Did we need to make this change?


    [gov4alpha] For scaffolds, replace scaffoldings of v1beta1 by using k8s.io/api/admission/v1 instead of k8s.io/api/admission/v1beta1 as v1beta1 is removed in latest k8s.

  - admissionv1beta1 "k8s.io/api/admission/v1beta1"
  + admissionv1 "k8s.io/api/admission/v1"

https://v1-28-x.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.28.0/

We don't use the gov4 plugin. But is this needed to run the operator on k8s 1.26?

@roypaulin
Copy link
Collaborator Author

Did we need to make this change?


    [gov4alpha] For scaffolds, replace scaffoldings of v1beta1 by using k8s.io/api/admission/v1 instead of k8s.io/api/admission/v1beta1 as v1beta1 is removed in latest k8s.

  - admissionv1beta1 "k8s.io/api/admission/v1beta1"
  + admissionv1 "k8s.io/api/admission/v1"

https://v1-28-x.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.28.0/

We don't use the gov4 plugin. But is this needed to run the operator on k8s 1.26?

Yes I read some doc on this and k8s.io/api/admission/v1beta1 has been deprecated for a while (since v1.19). Maybe we should just upgrade to v1? Any reason to stick to v1beta1?

@spilchen
Copy link
Collaborator

spilchen commented Apr 4, 2023

No reason to stick with v1beta1. The minimum k8s version we officially support is 1.21.1+. So, lets change it.

@spilchen spilchen merged commit 5c052ab into vertica:main Apr 5, 2023
@roypaulin roypaulin deleted the upgrade-sdk branch April 19, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants