Include metrics label to uniquely identify the database #300
+153
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a new label to all of the Prometheus metrics that the operator collects. We include the database name: e.g. db_name="vertdb". I am adding this to be in-sync with the server as it uses the same label. This will help allow us to pull metrics into the same dashboard for operator and server.
This changes earlier commits in the PR. I know use the revive_instance_id as a unique identifier of metrics for a cluster. This will be in-sync with the server metrics, so we will be able to associate operator metrics with the server with the same life of the cluster.
spilchen
changed the title
spilchen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new label to all of the Prometheus metrics that the operator collects. We include the revive instance ID. Here is a sample metric:
The label
revive_instance_idwill allow us to match labels generated at the server. This will help allow us to pull metrics into the same dashboard for operator and server.