Allow local paths to share the same mount point #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bug fix for when the local paths (data, depot, catalog) all share the same mount location. Previous to this change, the pods in a statefulset would fail to start. It failed to start because they all inadvertently shared the same mount. This fixes this by adding a mount only if the local paths differ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix for when the local paths (data, depot, catalog) all share the same mount location. Previous to this change, the pods in a statefulset will fail to start if the paths are all the same. It fails to start because they all shared the same mount. This fixes it by adding a mount only if the local paths differ.